[PATCH]fdo#52636:VIEWING: unintuitive Heading for 'Enable experimental Features

Ivan Timofeev timofeev.i.s at gmail.com
Mon Aug 6 11:28:59 PDT 2012

Hi Joel,

On 02.08.2012 21:57, Joel Madero wrote:
> Here is an updated patch.

not that it is essential, but it is good if the commit message is 
wrapped so that it does not exceed a reasonable width (say 70-80 
characters). (Yes, my e-mail client seems unable to do that, ugh.)

>  Please enter the commit message for your changes. Lines starting
>  with '#' will be ignored, and an empty message aborts the commit.

Something wrong with your editor? These lines should start with '#' and 
be ignored, why they are in the commit message again?

> Text [ en-US ] = "Optional features" ;

uhm, IMHO "optional" means "not necessary in most cases, but sometimes 
might be helpful". So a user would think "Ok, let's enable all these, 
won't hurt anyway." But this features aren't stable and somewhat 
dangerous to enable, and

> -        Text [ en-US ] = "Enable experimental (unstable) features";
> +        Text [ en-US ] = "Enable experimental features";

makes it sound even more safe. Maybe "Unstable features" as a header then?

Another nit-picking:
you placed two labels in one row, not good IMHO: consider long 
translations. But then the last row could go out of the visible area, it 
would be great to check that - play with "#define ROW.." constants in
optgdlg.hrc, remove my ugly +6 in ROW14 etc... :)



More information about the LibreOffice mailing list