[Libreoffice-commits] -Werror=format-security

[Lubos Lunak]

On Tuesday 07 of August 2012, Michael Meeks wrote:
> On Tue, 2012-08-07 at 09:23 +0200, Stephan Bergmann wrote:
> > Folks, please do not pollute the sources with fprintf in the first
> > place.
>
> 	Of course that doesn't belong in master but ...
>
> >   Use SAL_INFO/SAL_WARN for permanent warning code (see
> > <http://wiki.documentfoundation.org/Development#Assertions_and_Logging>),
> > and use SAL_DEBUG for temporary debug output (that the LO git commit
> > hooks will prevent from accidentally becoming permanent).
>
> 	I always use fprintf and never these other things. I can never remember
> how to make SAL_WARN / SAL_INFO / SAL_DEBUG to actually output something
...
> 	And - unfortunately, there's no way re-explaining it is going to help
> me remember the detail ;-) -possibly- adding a:
>
> 	./soffice --help-debug
>
> 	section that explains what to set SAL_LOG to, and some of the other
> environment variables to set to debug various other things might help
> keep that near the front of people's minds but ...

 I know it may be hard getting used to the idea of something in this codebase 
being well-documented, but this stuff is, see sal/inc/sal/log.hxx .

-- 
 Lubos Lunak
 l.lunak at suse.cz