[PATCH] [PUSHED] IDE: PTR_CAST, ISA -> dynamic_cast

Michael Stahl mstahl at redhat.com
Tue Aug 7 06:57:52 PDT 2012


On 07/08/12 15:38, János Uray wrote:
> http://wiki.services.openoffice.org/wiki/Writer/Code_Conventions#Vetoed_Conventions
> says that C++ RTTI is preferred over <tools/rtti.hxx>.
> In my opinion, the best would be not using casts at all (using e.g.
> virtual functions instead).

yes, a lot of these things could be improved by replacing dynamic_cast
with new virtual functions; there is a lot of ancient code apparently
written by dyed-in-the-wool C/Pascal programmers that had trouble with
object oriented things.

by the way, Armin's aw080 branch over at AOO(i) removes tools/rtti.hxx
completely, though nobody has any idea when the _other_ enormous
refactorings in there will be finished....



More information about the LibreOffice mailing list