[ Patch ] fdo#37791 Insert selected text to Findbar by Ctrl+f

Miklos Vajna vmiklos at suse.cz
Fri Aug 10 01:27:45 PDT 2012


Hi Tamas,

On Fri, Aug 10, 2012 at 10:19:19AM +0200, zolniatamas at caesar.elte.hu wrote:
> +    String aString;

I know this is copied from existing code, but if you are at it, can't
you turn this into an OUString? most probably it'll work out of the box,
you just need to rename the class.

(See
http://wiki.documentfoundation.org/Development/String_Classes#Deprecated
)

> -                SetText( aString );
> +                SetText( String() );

Here as well.

> -                if ( sItemCommand == ".uno:FindText" )
> +                if ( sItemCommand == COMMAND_FINDTEXT )

Good catch. :)

Care to resubmit with this change, please?

Thanks,

Miklos


More information about the LibreOffice mailing list