[PUSHED] fdo#37791 Insert selected text to Findbar by Ctrl+f

Miklos Vajna vmiklos at suse.cz
Fri Aug 10 02:08:31 PDT 2012


Hi Tamas,

On Fri, Aug 10, 2012 at 10:57:12AM +0200, zolniatamas at caesar.elte.hu wrote:
> +    ::rtl::OUString aString;

Just for the future: you can use simply OUString here, in internal code
the ::rtl:: prefix is no longer necessary. (I corrected this before
pushing.)

> +    if ( aString.getLength() != 0 )

Anothor minor nit, there is isEmpty() for this purpose (forgot to
correct it before pushing, just keep in mind for your next patch).

Other than that, nice work, thanks! :)

Miklos


More information about the LibreOffice mailing list