[REVIEW 3-6 ] No more prereg, no more unopkg sync
sbergman at redhat.com
Mon Aug 13 05:21:07 PDT 2012
On 08/13/2012 01:48 PM, Michael Meeks wrote:
> IMHO I'd prefer to have an RC3 for 3.6.1 than the potential for
> regression by including this in 3.6.2 - and having the state-of-the-art
> code that is shared between master and -3-6 for testing seems sensible
> (to me).
In the end, I'd be fine either way. An additional review might make
sense when integrating it now.
> The only gotcha I spotted was the:
> @@ -222,18 +211,6 @@ NodeJava::NodeJava(Layer layer):
> constructor; but it seems we initialize m_layer earlier already so just
> remove a duplicate initialization.
Yes, the removed else-branch was redundant.
More information about the LibreOffice