[PATCH] fdo#47674 Calc: save settings for import ascii text dialog

[Eike Rathke]

Hi jumbo444,

On Friday, 2012-08-10 06:26:52 -0700, jumbo444 wrote:

> I propose a patch for fdo#47674

I'll follow up on that tomorrow.

> Open Text-CSV saved settings of ScImportAsciiDlg dialog, but not Paste >
> Unformatted Text and Data > Text to Columns.
> This patch adds two groups in Calc.xcs to save the settings (which are
> independent).
> cSep last parameter of ScImportAsciiDlg constructor was removed as it was
> useless (parameter is controlled by settings).

Browsing through it seems your approach is fine, I'll look at details
later.

> I set \t as default separator for both Paste Unformatted Text and Text to
> Columns. I set DetectSpecialNumbers at true as default for Paste Unformatted
> Text. Why is it not set to true for import CSV file? It seems to me to be
> the more common behavior.

That DetectSpecialNumbers may get in the way as it also detects
abbreviated dates and other not so obvious strings that can be converted
to numeric values. Many times that is not wanted for file data. Whether
it's good to have it enabled as default for clipboard and column data
I'm not sure. I think it doesn't harm to try..

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120813/c07abe49/attachment-0001.pgp>