[REVIEW 3-6] Fix pivot table import from xlsx (fdo#53456)

Kohei Yoshida kohei.yoshida at gmail.com
Mon Aug 13 14:16:28 PDT 2012


Hi there,

I'd like

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae296a60781a2b5d5b7523cbda3444e3dd21506f

cherry-picked into 3-6.

This fixes

https://bugs.freedesktop.org/show_bug.cgi?id=53456

The gist of the bug is that, pivot table would treat all formula cells 
within its source range as empty, and the reason was simply because the 
formula cells were imported *after* the pivot tables were 
initialized...(so they were indeed empty at the time of pivot table 
construction)

Simply switching the order to put the pivot table initialization after 
the formula cells fixes the problem.

Review and cherry-pick appreciated.  I think this one is a pretty safe & 
simple fix.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


More information about the LibreOffice mailing list