[PUSHED-3-6, REVIEW 3-6-1] fix crash in cond format export code with a "broken" document, fdo#53339

Kohei Yoshida kohei.yoshida at gmail.com
Wed Aug 15 11:46:26 PDT 2012

On 08/15/2012 06:59 AM, Michael Meeks wrote:
> On Tue, 2012-08-14 at 23:09 +0200, Markus Mohrhard wrote:
>> I'd like [1] to be backported to 3-6 and 3-6-1. It fixes a crash that
>> should only happen with this insane document but it is a safe fix and
>> can't harm in normal cases.
> 	Looks fine; just pushed to master. Looks like we should cout as well as
> fprintf to the magic pre-commit hooks :-)
> 	Another 2x reviews for -3-6-1 appreciated for:
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=3fefa69d6d316b9e38f12e3d3eb1fdd5896513cd

I'll give my sign-off.  It's a very simple null pointer check.

One more review needed for 3-6-1.


Kohei Yoshida, LibreOffice hacker, Calc

More information about the LibreOffice mailing list