[PUSHED] Re: [PATCH] Converting code to STL in SVX module
Michael Stahl
mstahl at redhat.com
Thu Aug 16 06:19:38 PDT 2012
On 15/08/12 14:08, Noel Grandin wrote:
> Hi
>
> Just when I thought I was done, more of the stuff crawls out.....
>
> These patches pass a full make check.
thanks, pushed
patch #10 has this, which (since the Remove is, uhm, removed) will
delete the same entry multiple times... also previously the elements
were removed at the end, now at the begin
> - if (aList.Count()>nEntryNum) { // maybe still too many entries
> - sal_uIntPtr nTooMuch=aList.Count()-nEntryNum;
> + if (aList.size()>nEntryNum) { // maybe still too many entries
> + sal_uIntPtr nTooMuch=aList.size()-nEntryNum;
> for (sal_uIntPtr nNum=0; nNum<nTooMuch; nNum++) {
> delete ImpGetEntry(nEntryNum);
> - aList.Remove(nEntryNum);
> }
> + aList.erase(aList.begin(), aList.begin() + nTooMuch);
More information about the LibreOffice
mailing list