[REVIEW 3-6] missing "<<" in fdo#53655: removing extensions\bundled fails on Win XP

Stephan Bergmann sbergman at redhat.com
Tue Aug 21 10:01:00 PDT 2012


On 08/21/2012 06:14 PM, Stephan Bergmann wrote:
> One more from the "oh no, not one more" department:
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8cdce148c76c93c5d41820610d6e6ac175e03a7>
> "fdo#53655: Ignore failure to remove directories (as happens on Windows
> XP)" fixes <https://bugs.freedesktop.org/show_bug.cgi?id=53655> "Install
> 3.6.1 RC 1 on 3.6.0 RC4, causes crash on startup" where, exclusively on
> Windows XP it appears, removing (empty) directories in
> %appdata%\LibreOffice\3\user\extensions\bundled fails with E_ACCESS.
>
> Please, one more time, review for backporting to libreoffice-3-6 and
> libreoffice-3-6-1.

Just noticed a missing "<<" in a SAL_WARN_IF in that commit, addressed 
on master now with 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=1316cfe8a72f7c7bc2f5ad7644a2d4c54b77fc8b> 
"Typo."

It does not negatively affect libreoffice-3-6-1, as SAL_WARN_IF expands 
to no code in production builds, but please review and backport to 
libreoffice-3-6.

Stephan


More information about the LibreOffice mailing list