[PUSHED] Change in core[libreoffice-3-5]: fdo#46249: UCBContentHelper::GetTitle must not fail for void...

Gerrit gerrit at gerrit.libreoffice.org
Wed Aug 22 09:22:24 PDT 2012


>From Michael Stahl <mstahl at redhat.com>:

Michael Stahl has submitted this change and it was merged.

Change subject: fdo#46249: UCBContentHelper::GetTitle must not fail for void property
......................................................................


fdo#46249: UCBContentHelper::GetTitle must not fail for void property

This was a regression introduced with 2af9040d38af7c7353855415dbea0134585058f3
"Cleaned up utl::UCBContentHelper."  GetSize exhibited the same problem and has
also been fixed.  IsYounger exhibits a similar problem, but has not been
addressed, as it is unclear what to return in case no dates can be compared; it
is only used in one place (handling SID_EDITDOC in
SfxViewFrame::ExecReload_Impl, sfx2/source/view/viewfrm.cxx) where, it appears,
only contents for which DateModified /does/ yield a non-void value are relevant.

(cherry picked from commit 27c7682e5e5859eb353443d6091143694a56bee8)

Conflicts:
	unotools/source/ucbhelper/ucbhelper.cxx

Change-Id: I748745a1d7f361f8f91be87d7356983ee7261b1e
---
M unotools/inc/unotools/ucbhelper.hxx
M unotools/source/ucbhelper/ucbhelper.cxx
2 files changed, 21 insertions(+), 9 deletions(-)

Approvals:
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/452
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I748745a1d7f361f8f91be87d7356983ee7261b1e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-5
Gerrit-Owner: Stephan Bergmann <sbergman at redhat.com>
Gerrit-Reviewer: Michael Stahl <mstahl at redhat.com>



More information about the LibreOffice mailing list