[REVIEW-3-6] fix for fdo#53979, fdo#54018, crash when sorting range with comment and another problem around comments

Kohei Yoshida kohei.yoshida at gmail.com
Mon Aug 27 07:37:21 PDT 2012


On 08/26/2012 02:35 PM, Markus Mohrhard wrote:
> Hey,
>
> the attached patch fixes two problems around sorting a range with
> comments. The first thing is that it fixes the crash in the two bug
> reports because the comments were inserted in the wrong place. I also
> noted that the current code sorts comments in the same col/row even if
> they are not in the selected range.

Yup, the change looks good.  Pushed to 3-6 with my sign-off.

> P.S. Please also push to master. I have no internet connection ATM
> when I use Linux so I can't push myself.

Pushed to master as well.  Thanks a lot!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc


More information about the LibreOffice mailing list