[PATCH] OUStringBuffer::remove( int ) -> truncate( int )

Luboš Luňák (via_Code_Review) gerrit at gerrit.libreoffice.org
Thu Dec 6 09:56:36 PST 2012


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1256/1

OUStringBuffer::remove( int ) -> truncate( int )

Although this may seem consistent with remove( int, int ), it is
in fact rather misleading API. The biggest offender is most probably
buffer.remove( 'a' ) , which definitely does not do what it suggests
to do.

Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
M sal/inc/rtl/ustrbuf.hxx
M svl/source/numbers/zformat.cxx
M xmloff/source/style/xmlnumfi.cxx
3 files changed, 10 insertions(+), 10 deletions(-)

To view, visit https://gerrit.libreoffice.org/1256
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luboš Luňák <l.lunak at suse.cz>
Gerrit-Reviewer: Norbert Thiebaud <nthiebaud at gmail.com>

More information about the LibreOffice mailing list