[PATCH] Change in core[libreoffice-3-6]: fdo#55289: fix crash in SwXShape::setPropertyValue:

Michael Stahl (via Code Review) gerrit at gerrit.libreoffice.org
Fri Dec 7 04:00:57 PST 2012


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/64/1264/1

fdo#55289: fix crash in SwXShape::setPropertyValue:

In the libreoffice-3-6 branch the docx import crashes here when setting
the anchor position of a shape, because the previous setting of the
AnchorType was not done properly: the position of the anchor in the
SwFmt did not match the actual position of the text attribute, so we get
these assertions: "Missing FlyInCnt-Hint." and crash.

This cannot be reproduced with the docx import on master, because on
master a different intermediate AnchorType is set, and transitioning
from that happens not to cause the crash.  But it can be reproduced with
a unit test.

The regression was introduced in libreoffice-3-6 with
backport commit bbbb10a0774b9da546557632cd09c4f6958f8939.

Change-Id: I394643e11862543177ba57958a26cd8ce06dc09c
(cherry picked from commit 01cd24df1ec7eaa53e9e2156d4d6890a7cc5996a)
M sw/qa/core/macros-test.cxx
M sw/source/core/unocore/unodraw.cxx
2 files changed, 49 insertions(+), 1 deletion(-)

To view, visit https://gerrit.libreoffice.org/1264
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I394643e11862543177ba57958a26cd8ce06dc09c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl <mstahl at redhat.com>

More information about the LibreOffice mailing list