Using config_xxx.h instead of -DHAVE_XXX

Lubos Lunak l.lunak at
Fri Dec 7 09:42:37 PST 2012


 currently our build system adds -DHAVE_XXX options to the compile command 
line for various settings, which does not quite scale, and does not cause 
relevant files to rebuild, so the common practice nowadays is to use config.h 

 The attached patches implement this change and add one new test (together 
with bringing OUStringBuffer::append(bool) in again). Unless somebody sees a 
problem with this, I'll push them soon.

 There are more such -D options that could be changed, although with some it'd 
be better be careful, e.g. OSL_DEBUG can't go there, because it can be 
overriden by command-line, and I'm not sure if adding #include 
<config_global.h> to sal/config.h would be really included everywhere where 

 Lubos Lunak
 l.lunak at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-use-config_xxx.h-files-instead-of-DHAVE_XXX-on-the-c.patch
Type: text/x-diff
Size: 19909 bytes
Desc: not available
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-add-rtl-OUStringBuffer-append-bool.patch
Type: text/x-diff
Size: 5325 bytes
Desc: not available
URL: <>

More information about the LibreOffice mailing list