Addin exceptions in SvStream

Stephan Bergmann sbergman at
Tue Dec 11 00:39:43 PST 2012

On 12/10/2012 10:41 PM, Michael Meeks wrote:
> On Mon, 2012-12-10 at 10:27 -0500, Marc-André Laverdière wrote:
>> I am doing some proactive hardening of the image filters these days,
>> and I have to say that there is a lot of code like this:
>> *stream >> meh;
> 	Which is IMHO intrinsically broken; I'd prefer to see that as:
> 	meh = stream.ReadInt32();
> 	Where we default to zero for end-of stream and bad streams - rather
> than uninitialized variables. Not only does it get rid of the fragile
> operator overload, make the code clearer by having the type information
> at the call-site etc. It also avoids using exceptions ;-)

Getting rid of >> overloads and introducing (optional) exceptions are 


More information about the LibreOffice mailing list