Addin exceptions in SvStream

[Marc-André Laverdière]

My reply was accidentally sent to Michael Stahl only. Ooops.

I feel that this behavior of SvStream not to change the parameter in
case of a broken stream should be changed. I am not sure why that is
there.

I have a partial change to that that I am attaching for review. I am
not getting the logic on the chars so things aren't fixed.

The rest, I ran it over a make check and nothing broke - that doesn't
necessarily mean that the fix is harmless...
Marc-André LAVERDIÈRE
"Perseverance must finish its work so that you may be mature and complete,
not lacking anything." -James 1:4
http://asimplediscipleslife.blogspot.com/
mlaverd.theunixplace.com



On Tue, Dec 11, 2012 at 10:05 AM, Michael Stahl <mstahl at redhat.com> wrote:
> On 11/12/12 15:57, Stephan Bergmann wrote:
>> Exceptions are certainly no silver bullet (semantically they are
>> ~equivalent to encoding exception information in function return values
>> and explicitly handling those return values accordingly, so the "endemic
>> bloat" claim meets skepticism)
>
> well in practice in our code the alternative to exceptions is not
> "explicitly handling those return values" but simply ignoring the error
> conditions which usually tends to results in smaller code  ;-)
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Defaulting-to-0-on-bad-stream-read-WIP.patch
Type: application/octet-stream
Size: 5633 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121213/dd16a57a/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Broken-fix-for-SvStream-operator-on-chars.patch
Type: application/octet-stream
Size: 1497 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121213/dd16a57a/attachment-0001.obj>