[RFC] syslog output from SAL_* messages

[Riccardo Magliocchetti]

Hi Miklos,

Il 18/12/2012 09:10, Miklos Vajna ha scritto:
> On Mon, Dec 17, 2012 at 09:15:21PM +0100, Riccardo Magliocchetti<riccardo.magliocchetti at gmail.com>  wrote:
>> i've refreshed my patch for adding possibility to send SAL_*
>> messages to syslog. I have two issues:
>> - am not able to send the ENABLE_SYSLOG definition down to
>> sal/osl/unx/salinit.cxx
>> - if i add calls to SAL_INFO in vcl/headless/headlessinst.cxx like,
>> i see the fprintf but i don't see the SAL_INFO one. Tried with
>> SAL_WARN, same result.
>
> What environment variable did you use? SAL_INFO is disabled by default,
> you need something like SAL_LOG=+INFO.vcl to get it. The trailing
> newline is not necessary.

I totally overlooked this :) shouldn't i have seen the WARNs though? In 
sal/osl/all/log.cxx:87 getEnvironmentVariable "+WARN" is default when 
std::getenv("SAL_LOG") == 0. Btw in practice probably doesn't count but 
shouldn't these be checks against NULL instead of 0?

thanks,
riccardo