[REVIEW] domain-mapper import speedup patch ...

Michael Meeks michael.meeks at suse.com
Fri Dec 21 08:55:44 PST 2012

Hi guys,

	Still annoyed by the (increasingly small) RTF performance
regressions[1], and given that the profiling now shows the
domain-mapper's use/abuse of the core as being the main factor (at least
for file 3 in [1]).

	I attach a prototype patch. It passes make check and make slowcheck in
sw/ (not tried subsequentcheck).

	There are probably better ways to do this :-) clearly it would be nice
to manage layered SfxItemSets via UNO in an even more performant and
elegant way that doesn't rely on great big uno PropertyValue sequences
getting sent repeatedly and so on. Anyhow the attached gives a
reasonable win on RTF import: 25% faster or so. It's hard to see how it
could make things much perform worse. It has a FIXME - I'm unclear
exactly what's going on there. Clearly I'm wandering at the edge of my
competence wrt. the writer bits here, so help/encouragement appreciated.

	Thoughts / review etc. much appreciated; if no-one screams I'm inclined
to remove the CursorMap property checks I don't like and push it to
master (which is a threat to focus review incidentally ;-).

	Thanks !


[1] - https://bugs.freedesktop.org/show_bug.cgi?id=44736
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-44736-set-and-fetch-multiple-properties-concurre.patch
Type: text/x-patch
Size: 8902 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121221/0530ab8a/attachment-0001.bin>

More information about the LibreOffice mailing list