[PATCH] Change in core[libreoffice-3-6]: fdo#47553: UniscribeLayout: adjust mnSubStringMin

[Michael Stahl (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1467

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1467/1

fdo#47553: UniscribeLayout: adjust mnSubStringMin

... to actual minimum so that the fix for fdo#33090 in
UniscribeLayout::GetNextGlyphs subtracts exactly the right number.

The original value of mnSubStringMin is guessed and may be up to 8
smaller than the actual start of the first VisualItem.

For the bugdoc it happens that sometimes it's too small by 8 and then
the wrong entries in mpGlyphs2Chars are initialized and then apparently
there are single glyphs that represent multiple characters and so
GetNextGlyphs returns a -1 character which is invalid.

 ->GetNextGlyphs dir 1 36 mnSubStringMin 28
 ->GetNextGlyphs g2c #1 [8] = 36
 ->GetNextGlyphs g2c #1 [9] = 37
 ->GetNextGlyphs g2c #1 [10] = 38
 ->GetNextGlyphs g2c #1 [11] = 39
 ->GetNextGlyphs g2c #1 [12] = 40
 ->GetNextGlyphs g2c #2 [4] = 40
 ->GetNextGlyphs g2c #2 [3] = 39
 ->GetNextGlyphs g2c #2 [1] = 38
 ->GetNextGlyphs g2c #2 [1] = 37
 ->GetNextGlyphs g2c #2 [0] = 36
...
 ->GetNextGlyphs init nCharPos -1
 ->GetNextGlyphs g2c [2]  nCharPos -1
 ->GetNextGlyphs set pCharPosAry -1
layout[0]->GetNextGlyphs 768,1024 a1800 c-1 0

Change-Id: Ie33ec797a412aa898bec3f4e8f97b88dcfed4d11
(cherry picked from commit cec68bceba9aa1e984d74897fcd7bf4db702d14b)
---
M vcl/win/source/gdi/winlayout.cxx
1 file changed, 9 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1467
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie33ec797a412aa898bec3f4e8f97b88dcfed4d11
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Michael Stahl <mstahl at redhat.com>