Questions about Bug 39370:RTL / LTR and right/left alignment buttons' icons should not be reversed in RTL interface.

[Manal M. Alhassoun]

Hello all,

Here is the bug's page: https://bugs.freedesktop.org/show_bug.cgi?id=39370


1- First, In the RTL UI, Does the toolbar automatically flips the order and alignment of its items ?

2- I'm thinking to solve this bug by adding a new Formatting Toolbar for the RTL UI that have the buttons in their preferable location.
I was able to add a new toolbar, but couldn't change the default one.

What do you think about this approach?
How can I determine the default toolbars?


3- As indicated in the bugzilla comments #11
The Bullets and Numbering icons are actually mirrored in RTL UI, not only in the reverse order.
For me I don't think this is a problem for the Bullets button, but for the Numbering it's really look weird.
I tried to solve this by prevent the Numbering button from mirroring:

framework/source/uielement/toolbarmanager.cxx:ToolBarManager::UpdateImageOrientation()
if( Application::GetSettings().GetLayoutRTL() )

if(!((aMirrorCmd == ".uno:DefaultNumbering") || (aMirrorCmd == ".uno:NumberOrNoNumber")))

{

            pIter = m_aCommandMap.find( aMirrorCmd );

            if ( pIter != m_aCommandMap.end() )
               pIter->second.bMirrored = sal_True;

}
What do you think?
It seems to work, but I'm not sure if it's the "correct" way to do it

Any suggestion or code pointers would be appreciated.

P.S. I'm a beginner in LibreOffice development so sorry for any silly question, but I really want to learn : )

Thanks in advance.

________________________
Regards,
Manal M. Alhassoun
Motah Program, KACST
http://www.motah.org.sa<http://www.motah.org.sa/>

Warning: This message and its attachment, if any, are confidential and may contain information protected by law. If you are not the intended recipient, please contact the sender immediately and delete the message and its attachment, if any. You should not copy the message and its attachment, if any, or disclose its contents to any other person or use it for any purpose. Statements and opinions expressed in this e-mail and its attachment, if any, are those of the sender, and do not necessarily reflect those of King Abdulaziz city for Science and Technology (KACST) in the Kingdom of Saudi Arabia. KACST accepts no liability for any damage caused by this email.

?????: ??? ??????? ??? ????? ?? ?????? (?? ????) ???? ????? ???? ?? ????? ??? ??????? ????? ????? ???????. ??? ?? ??? ????? ?????? ???? ??????? ???? ???? ????? ??????? ???? ?????? ????? ???? ??????? ????????? (?? ????)? ??? ???? ?? ??? ?? ????? ??? ??????? ?? ???????? (?? ????) ?? ?? ??? ????? ?? ????? ?????????? ????? ?? ????????? ??? ???. ????? ??? ???? ??? ??????? ????????? (?? ????) ???? ?? ??? ??????? ???? ???????? ??? ????? ????? ????????? ?????? ???????? ???????? ??????? ????????? ??? ????? ??????? ?? ??????? ?? ??????? ??????? ?? ?? ?? ?????? ??? ??????.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121224/6a5906fc/attachment-0001.html>