[Libreoffice-commits] .: solenv/gbuild svl/source sw/source tools/source

[Lubos Lunak]

On Thursday 27 of December 2012, Libreoffice Gerrit user wrote:
> commit c318f3b0224a57102614be0efec4b49c80a3aa82
> Author: Tor Lillqvist <tml at iki.fi>
> Date:   Thu Dec 27 13:07:11 2012 +0200
>
>     Check for _MSC_VER instead of MSC in sources
>
>     Change-Id: Ibaf2501e6b655913963a53c1cd63668f1c4cccb2
>
> diff --git a/solenv/gbuild/platform/com_MSC_defs.mk
> b/solenv/gbuild/platform/com_MSC_defs.mk index 1e9ac46..1e8004f 100644
> --- a/solenv/gbuild/platform/com_MSC_defs.mk
> +++ b/solenv/gbuild/platform/com_MSC_defs.mk
> @@ -50,7 +50,6 @@ gb_CXX := $(CXX)
>  endif
>
>  gb_COMPILERDEFS := \
> -	-DMSC \
>  	-D_CRT_NON_CONFORMING_SWPRINTFS \
>  	-D_CRT_NONSTDC_NO_DEPRECATE \

 You have not removed all usage of this #define. I can see a number of '#ifdef 
MSC' in the sources (and I don't know if there are also other variants).

-- 
 Lubos Lunak
 l.lunak at suse.cz