[PATCH] Fix wrong default return values

Werner Körner (via_Code_Review) gerrit at gerrit.libreoffice.org
Sat Dec 29 03:50:08 PST 2012


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1496

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/1496/1

Fix wrong default return values

Change-Id: Iba1a46b91a79e41fae1661d9d3742d6195e4c4dc
---
M cui/source/tabpages/page.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index 50b6a57..dd97197 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -95,7 +95,7 @@
     for ( sal_uInt16 i = 0; i < SAL_N_ELEMENTS(aArr); ++i )
         if ( aArr[i] == ( nUsage & 0x000f ) )
             return i;
-    return SVX_PAGE_ALL;
+    return 0;
 }
 
 // -----------------------------------------------------------------------
@@ -103,7 +103,7 @@
 sal_uInt16 PosToPageUsage_Impl( sal_uInt16 nPos )
 {
     if ( nPos >= SAL_N_ELEMENTS(aArr) )
-        return 0;
+        return SVX_PAGE_ALL;
     return aArr[nPos];
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/1496
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba1a46b91a79e41fae1661d9d3742d6195e4c4dc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Werner Körner <wk661lo at gmail.com>



More information about the LibreOffice mailing list