[Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

Noel Power nopower at suse.com
Wed Feb 1 03:58:34 PST 2012

Hi Noel
On 31/01/12 14:24, Noel Grandin wrote:
> sorry, that should be "converted to std::vector"
you mean boost::ptr_vector I think :-)

Hope I didn't miss anything this time, I made some minor changes ( see 
attached patch )

e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as the 
vector will go out of scope here anyway and delete the container 
contents. Also I changed slightly the code in IMPL_LINK(SdPresLayoutDlg, 
ClickLoadHdl, void *, EMPTYARG) and got rid of a String copy and 
slightly changed the calculation of 'nId' for maVS.SelectItem

I am currently running make check on it this time ;-) assuming it works 
and no other objection to the patch I will commit to master
thanks again for the patch.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120201/230f8c6b/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SdPresLayoutDlg-convert-from-List-to-ptr-vector2-again.diff
Type: text/x-patch
Size: 5803 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120201/230f8c6b/attachment.bin>

More information about the LibreOffice mailing list