[Libreoffice] Same expression on both sides of '&&' on editeng/source/accessibility/AccessibleStaticTextBase.cxx

Eike Rathke erack at redhat.com
Wed Feb 1 07:17:51 PST 2012


Hi julien2412,

On Tuesday, 2012-01-31 13:36:41 -0800, julien2412 wrote:

> Should it be just replaced by this :
>           if( aTextSegment.SegmentStart != -1 &&
>                aTextSegment.SegmentEnd != -1 )
> 
> or is it not so obvious ?

If only SegmentEnd was -1 and SegmentStart was not, then the state of
that segement would had been dubious and adding an offset to both
wouldn't make sense I think. So yes, this seems to be the solution.
Can't be worse than it was where it ignored SegmentEnd and looked like
a copy&paste error.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120201/efd05bc2/attachment-0001.pgp>


More information about the LibreOffice mailing list