[Libreoffice] [PATCH] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions
albert.thuswaldner at gmail.com
Fri Feb 3 02:47:08 PST 2012
This is an old topic again...
On Tue, Jul 12, 2011 at 00:26, Markus Mohrhard
<markus.mohrhard at googlemail.com> wrote:
> Hello Albert,
> nice work but I have some comments.
> Operator== should have return type bool and not int(I saw that ScDocOptions
> used int too, but I have changed that already).
> But all in all I think we shouldn't introduce operator== there.
> I didn't like the old approach with operator== but after your changes it
> seems even more unnecessary. Let's just use ScAppOptions directly and set
> the keybinding even if it is the same keybinding as the old one. With this
> approach you don't need to compare two ScAppOptions instances and there is
> no need for operator== anymore. And all in all I think we can remove the two
> dynamically created ScAppOption instances with this approach.
I have updated the patch according to Markus comments above, removing
the check to see if the keybinding option has been modified. A side
effect of the above is that return type sal_Bool of
ScTpCompatOptions::FillItemSet is not needed anymore (at the moment i
have set it to always return true). In the next iteration I plan to
check what to do with this.
Before I do that it would be nice If someone could have a look at my
new patch. It is good, I plan to do the same thing to the Formula and
BTW: will the work on simplified C++ configuration access have any
impact on this part of the code?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 19576 bytes
Desc: not available
More information about the LibreOffice