l10ntools: GetXrmFile() nearly equal to GetCfgFile()

Stephan Bergmann sbergman at redhat.com
Mon Feb 6 00:24:40 PST 2012

On 02/05/2012 09:09 PM, Chr. Rossmanith wrote:
> simian detected 21 duplicate lines in the following files:
> l10ntools/source/xrmmerge.cxx
> l10ntools/source/cfgmerge.cxx
> But as far as I can see the methods GetXrmFile() and GetCfgFile() seem
> to be copy&pasted with minor modifications for ByteString removal and an
> additional exit(-13). It might be enough to have one of them and rename
> it to match both usages in lex files?

I'm working on l10ntools at the moment, hoping to get them off using 
things from the tools module (as that would be a prerequisite for using 
the new simplified configuration stuff in low level modules).  The first 
part is more or less mechanically getting rid of tools strings usage in 
l10ntools, but I already noticed that the code would probably benefit 
from some more thorough clean up, anyway.


More information about the LibreOffice mailing list