[Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Albert Thuswaldner albert.thuswaldner at gmail.com
Thu Feb 9 06:53:03 PST 2012


> Given that, I still think it's better (and easier) to check for every
> key-press, but instead of launching an error dialog for an illegal name,
> just put the old legal name back into the text box and sound an beep or
> something.  That's less intrusive than a big dialog being thrown right
> in your face.  I do exactly that for the argument separator value inputs
> in the Formula option page.

So I have improved the patch according to Kohei's suggestion above.
Now I store the prefix at each key-stroke and check for illegal
characters. When an illegal character is entered, the text is reverted
back to the last good prefix. (So basically the same as for the
separators in the formula options dialog)

The patch also fixes the UI glitches.

So it all should be well - but it is not!

At least I get two annoying bugs:
1) The cursor moves In front of the text when the Prefix is reverted.
2) When trying to delete text in the edit box, the last character
sticks (can't be deleted).

Does someone have a clue whats going on?

To finish this feature I also would like to add some type of cue.  It
would be great if there would be some kind of standard to follow here
(is there?).

Below I just list the different options (including possible pros/cons)
that I can think of at the moment:

1) Error dialog
+ Grabs attention
+ Space to provide a meaningful error message.
- too in your face

2) FixedLine message
+ Not in-your-face.
- Takes up space
- Only space for short error message

3) System bell
+ Grabs attention
- Utterly annoying IMO

4) Visual bell (tinted red flashing of edit field)
+ Subtile and effective way of feedback.
- ?

5.) Icon (warning sign or exclamation mark)
+ Can be made click-able to give additional information.
- Takes up space.

6.) Balloon message
+ ?
- ?

If it was up to me I would go for the visual bell. Any thoughts on this?

Thanks for reading my ramblings. ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Improvment-of-Custom-Sheet-Prefix-Option.patch
Type: text/x-patch
Size: 5034 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120209/02591605/attachment-0001.bin>

More information about the LibreOffice mailing list