smoketest - ABORT_ON_ASSERTION needed ? + gbuild patch

[Matúš Kukan]

Hello,

I'm sending patches to gbuild'ize smoketest, so that there is chance
to review before pushing.
Zip_* makefiles are little bit tricky.

I was little confused by ABORT_ON_ASSERTION = TRUE in smoketest's
makefile.mk which seems to be used only in installationtest.mk not
included here.
So I chose to ignore that.
But then DBGSV_ERROR_OUT is always 'shell' ? So no point to use
getenv( "DBGSV_ERROR_OUT" ) [1] ?
And the same for SAL_DIAGNOSE_ABORT which is always not defined and is
used [2] ?

My guess is ABORT_ON_ASSERTION = TRUE was supposed to be in
smoketestoo_native/makefile.mk,
see also PRJNAME = smoketestoo_native in smoketest/makefile.mk [3]

What do you think ? Do we need these variables ?

Matus

[1] http://opengrok.libreoffice.org/xref/core/tools/source/debug/debug.cxx#732
[2] http://opengrok.libreoffice.org/search?q=SAL_DIAGNOSE_ABORT&project=core&defs=&refs=&path=&hist=
[3] http://cgit.freedesktop.org/libreoffice/core/tree/smoketest/makefile.mk#n27
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gbuild-Zip-clean-properly-all-created-targets-on-mak.patch
Type: text/x-patch
Size: 2269 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120212/b9ef57ed/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-gbuild-Zip-allow-to-add-command-line-options-when-zi.patch
Type: text/x-patch
Size: 738 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120212/b9ef57ed/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-smoketest-convert-to-gbuild.patch
Type: text/x-patch
Size: 29802 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120212/b9ef57ed/attachment-0005.bin>