[PATCH] [PUSHED, modified] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

[Albert Thuswaldner]

Hi Kohei,

On Mon, Feb 6, 2012 at 20:56, Kohei Yoshida <kohei.yoshida at suse.com> wrote:
> Hi Albert,
>
> On Mon, 2012-02-06 at 20:48 +0100, Albert Thuswaldner wrote:
>> Hi,
>>
>> On Mon, Feb 6, 2012 at 19:48, Kohei Yoshida <kohei.yoshida at suse.com> wrote:
>> > On Mon, 2012-02-06 at 11:49 -0500, Kohei Yoshida wrote:
>> >
>> >> Let me spend some time on this, and will
>> >> get back to you.
>> >
>> > Done.  This is what I've committed:
>> >
>> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=28ff7a37e66c8746a0b176b4ea25e20c1cd135c5
>> >
>>
>> Thanks for having a look at this. Ok, it required more changes to get
>> it to work.
>>
>> Do you mind if I have a go at moving the Formula and Defaults options
>> in the same manner?
>
> Not at all.  Go for it. :-)
>

I have worked with converting the Formula options. However, while
doing the work and looking through the code I have started to question
if this conversion is such a good idea in this case?

Without knowing the exact difference between AppOptions and DocOptions
it is this this bit that worries me:

http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/impop.cxx#158

Seems that the excel import filter is setting some of these formula
options, better to keep those as DocOptions  then?

/Albert