smoketest - ABORT_ON_ASSERTION needed ? + gbuild patch

[Caolán McNamara]

On Sun, 2012-02-12 at 15:41 +0100, Matúš Kukan wrote:
> My guess is ABORT_ON_ASSERTION = TRUE was supposed to be in
> smoketestoo_native/makefile.mk

Yeah, that was where it was supposed to be, and that would tweak
solenv/./inc/installationtest.mk to toggle on SAL_DIAGNOSE_ABORT and
DBGSV_ERROR_OUT=abort to make the various sal/tools warnings into aborts
to give an even-stricter smoketest run. Which would make getenv
"DBGSV_ERROR_OUT" useful again and so forth.

> What do you think ? Do we need these variables ?

in "smoketest" which just builds the smoketest stuff itself, and doesn't
execute it, then nah, its clearly just a copied and pasted makefile from
smoketestoo_native which used to build and run the smoketest. 

I wonder if our smoketest run is clean enough to put ABORT_ON_ASSERTION
back into smoketestoo_native/makefile.mk

C.