[PUSHED][PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar
caolanm at redhat.com
Mon Feb 13 06:20:27 PST 2012
On Thu, 2012-02-09 at 21:38 +0400, Ivan Timofeev wrote:
> actually there was not a scrollbar appearing at the bottom, there was a
> border. :)
> so in normal mode we use IsVisible(false), that checks for
> SwScrollbar::bVisible, regardless of the real visibility. The next line:
> SetBorderPixel( rToFill );
> passes rToFill to SfxViewFrame::SetBorderPixelImpl, where it is used for
> some window size manipulations... Use of IsVisible(true), that checks
> for the real visibility, fixes the problem. The patch is attached.
> Please tell me what do you think about it. :)
Well, as far as I can tell from testing the problem you're trying to
fix, and testing the original report of
https://issues.apache.org/ooo/show_bug.cgi?id=32913 they both seems too
work fine with your code with view->print layout and view->web layout.
So I've pushed it now :-)
Its all way too complicated for me to follow. Someone brave needs to
remove the EnhancedShow, bVisible etc etc and strip it down to just the
normal scrollbar class and see what we actually lose doing that, and if
we do lose something, then sanely put that functionality back with
properly named methods that indicate their purpose better.
More information about the LibreOffice