[REVIEW 3-5] Fix for a crasher during copy-n-paste from Excel.

Kohei Yoshida kohei.yoshida at gmail.com
Mon Feb 13 09:40:11 PST 2012


Attached change (not yet committed to master) will fix a crasher bug
which is one of the bugs reported in

https://bugs.freedesktop.org/show_bug.cgi?id=45916

It originally comes from

https://issues.apache.org/ooo/show_bug.cgi?id=118851

There were several ways to think this as far as I could see. I've
settled with the attached change because the ScFormulaCell code
appears to assume that we always have a non-NULL pCode instance beyond
its construction.  The problem happened when calc was not able to
compile the formula string for whatever reason, in which case pCode
would remain NULL after the Compile is called in one of its
constructors.

Review & sign-off for the 3-5 branch appreciated.  If it looks good,
feel free to push it to master as well.

Kohei
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-45916-Ensure-formula-cell-s-pCode-isn-t-NULL-eve.patch
Type: application/octet-stream
Size: 893 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120213/1d24e018/attachment-0001.obj>


More information about the LibreOffice mailing list