[REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

Stephan Bergmann sbergman at redhat.com
Tue Feb 14 00:14:09 PST 2012


On 02/13/2012 11:21 PM, Matúš Kukan wrote:
> On 12 February 2012 23:51, Matúš Kukan<matus.kukan at gmail.com>  wrote:
>> Do not push them without improvement, make check fails for me.
>> Attached diff solves one problem but still there is something wrong.
>
> Well, I was fooled by smoketest/com/sun/star/comp/smoketest/makefile.mk
> There is javamaker involved, but the produced .class file does not end
> up in TestExtension.jar
> So the call to javamaker it's pointless ..whatever.
>
> Then I also tried to remove TestExtension.rdb from TestExtension.oxt
> and make check was also successful.
> So, can I remove TestExtension.idl file ? Anybody has opinion about this ?

The TestExtension.rdb type library and the TestExtension.idl new-style 
service definition should indeed be unnecessary.  The only use of the 
corresponding service is via BASIC createUnoService.

Stephan


More information about the LibreOffice mailing list