[REVIEW] [PATCH]bug 44516 improved label and business card document creation

[Winfried Donkers]

Olivier Hallot wrote (14 februari 2012)

>The new schema with the paper size will work with older versions of
>LibreOffice and OpenOffice? In other words, if I replace Labels.xcu from
>older OOo, with the new one,  is it going to break the label feature or
>not of OOo?
It will work with 'old style' custom label definitions (in registrymodifications.xcu)
and update this to 'new style' definition when used.
If you put the new Labels.xcu (and not the associated C++-code changes) in an
older OOo, it should work, as the older OOo (or LibO) reads a fixed numer of values 
from Labels.xcu. So, it will not read the page dimensions, even if they are there.
I have tested with 'old style' custom label definitions (in registrymodifications.xcu)
and the patch; that woks fine.
I have not tested the new Labels.xcu with old OOo or old LibO; IMHO you'll need to 
compile and build first.

>I ask that because I have a Label.xcu in an extension, and if I modify
>it for tre new schema, I need to know in order to update the version.
I have not tested with extensions. Are the label definitions read in the extension?
If so, I presume you use the class SwLabItem to fill with the label definition. The
patched SwLabItem has been expanded with page dimensions.
(Possibly I don't understand what you mean exactly)

Winfried