[Libreoffice-commits] "Remove unused VolumeDevice functions and related code"

[Stephan Bergmann]

On 02/05/2012 09:52 PM, François Tigeot wrote:
>   sal/inc/osl/file.h                |   43 --------------------
>   sal/inc/osl/file.hxx              |   28 -------------
>   sal/osl/unx/file_volume.cxx       |   80 --------------------------------------
>   sal/osl/w32/file_dirvol.cxx       |   18 --------
>   sal/qa/helper/gcov/deprecated.txt |    2
>   sal/util/sal.map                  |    2
>   6 files changed, 173 deletions(-)
>
> New commits:
> commit 32009128e4c77cfd6506ab50a5345776de8144e6
> Author: François Tigeot<ftigeot at wolfpond.org>
> Date:   Sun Feb 5 18:33:57 2012 +0100
>
>      Remove unused VolumeDevice functions and related code
>
[...]
> diff --git a/sal/util/sal.map b/sal/util/sal.map
> index 472ea8f..338854d 100644
> --- a/sal/util/sal.map
> +++ b/sal/util/sal.map
> @@ -443,8 +443,6 @@ UDK_3_0_0 {
>           osl_getSystemTimeFromLocalTime;
>           osl_getAbsoluteFileURL;
>
> -        osl_unmountVolumeDevice;
> -        osl_automountVolumeDevice;
>           osl_releaseVolumeDeviceHandle;
>           osl_getVolumeDeviceMountPath;
>           osl_acquireVolumeDeviceHandle;

I'm not sure this change is a good idea, given that it incompatibly 
changes the stable URE interface.  (Arguably, those functions are of ~no 
use, but changing existing sections of sal.map post-facto always feels 
like a no-no to me.)

Stephan