connectivity::ORowSetValue cleanup and behaviour

Lionel Elie Mamane lionel at
Wed Feb 15 06:01:15 PST 2012

On Wed, Feb 15, 2012 at 01:55:34PM +0100, Lionel Elie Mamane wrote:

> 2) Signed integers and unsigned integers never compare equal. But an
>    unsigned integer compares equal to the corresponding float...

>    Errr... They obviously should?

I misread the code... Need coffee. integers never compare equal to
floats, they don't even compare equal to the corresponding integer of
different size? E.g. 5 as a 16-bit integer is not equal to 5 as a
32-bit integer.

I'm suddenly more shy about changing that... The intended semantics
seem different, but OTOH,
frm::OListBoxModel::translateDbColumnToControlValue clearly expects
wider semantics (more things are equal). Dunno about other callers.

Mainly, I see no reason why floats of different subtypes should
compare equal, but not integers.

Thinking about it.


More information about the LibreOffice mailing list