[PATCH] [core/vcl/source/window/splitwin.cxx:2047] -> [core/vcl/source/window/splitwin.cxx:2045]: (style) Found duplicate branches for if and else.

Stephan Bergmann sbergman at redhat.com
Thu Feb 16 01:02:29 PST 2012


On 02/16/2012 09:35 AM, Riccardo Magliocchetti wrote:
> Otherwise you can simplify it even more:
>
> sal_Bool bLeft = (meAlign == WINDOWALIGN_TOP || meAlign ==
> WINDOWALIGN_LEFT) ? sal_False : sal_True;

... which of course reduces to

> bool bLeft = !(meAlign == WINDOWALIGN_TOP || meAlign == WINDOWALIGN_LEFT);

or

> bool bLeft = meAlign == WINDOWALIGN_RIGHT || meAlign == WINDOWALIGN_BOTTOM

given that WindowAlign has exactly those four members (and it makes the 
name "bLeft" look odd...).

Stephan


More information about the LibreOffice mailing list