[ANN] Referencing bugs in commits

Lionel Elie Mamane lionel at mamane.lu
Fri Feb 17 00:23:07 PST 2012


On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote:

> whenever you are committing / pushing to git, and you
> reference the bugs.freedesktop.org bug in the commit message, it will
> automatically appear as a comment in the bug :-)

It seems not to happen this morning. In general, after how much time
after commit should we get worried and report it?

> ----- 8< -----
> fdo#45748: Don't use empty pages for computing the page break position
> ----- 8< -----

> It will result in the following comment in bugzilla:

> https://bugs.freedesktop.org/show_bug.cgi?id=45748#c7

It says:

 $AUTHOR commited a patch related to this issue to "$BRANCH"

That's misleading. See e.g.
https://bugs.freedesktop.org/show_bug.cgi?id=45748#c9
and
http://cgit.freedesktop.org/libreoffice/core/commit/?id=66cf06ebdd4eeb95e801de114af06b49119fc7fe&g=libreoffice-3-5
Committed by Tor, but authored by Cédric. The message in the bug says
"Cédric committed".

I would suggest one of:

 A patch by $AUTHOR related to this issue was committed to "$BRANCH"

(should it be "has been committed" maybe?)

or

 $COMMITTER committed a patch by $AUTHOR related to this issue to "$BRANCH"

or
 $AUTHOR's patch related to this issue was/has been committed to "$BRANCH"

-- 
Lionel


More information about the LibreOffice mailing list