[PATCH] Remove "<foo>::existence" Perl modules.

[Tim Retout]

This patch series removes several versions of Perl modules named
<foo>::existence - the functions can be reimplemented with the "grep"
keyword.

The most arguably useful functions were get_specified_file{,by_name}
from installer::existence.  These encapsulated a small amount of
knowledge of a consistent hashref format that represents a file in the
installer code (i.e. a known hash key).  However, each of the last
three patches are still net code removals, and I suspect that getting
the grep inlined into the caller functions might help with refactoring
later.

Some error messages may change in patch 9, but the error message logic
in get_specified_file_by_name was not clear to me, (even checking the
context of CWS nativefixer6 that introduced it):

    if ( $installer::globals::patch) {
        $errorline .= "intro.bmp must be part of every patch [...]

If there's a reason to preserve that, I can revise those bits.

Oh, and there should be two new unit tests in there, too - not
complete code coverage by any means, but they were useful during
development to prove that I wasn't breaking the tested functions.

Now that I've done such a huge patch series, I wonder if there was a
better way to approach this to make it easier to review... :(

Kind regards,

-- 
Tim Retout <tim at retout.co.uk>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-unused-par2script-existence.patch
Type: text/x-patch
Size: 3029 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Remove-unused-pre2par-existence.patch
Type: text/x-patch
Size: 3088 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Use-Exporter-in-packager-work-and-add-unit-test.patch
Type: text/x-patch
Size: 3163 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Remove-packager-existence-and-clean-up-packager-work.patch
Type: text/x-patch
Size: 6232 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Use-Exporter-in-installer-setupscript-and-add-unit-t.patch
Type: text/x-patch
Size: 4113 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Remove-installer-existence-exists_in_array_of_hashes.patch
Type: text/x-patch
Size: 2761 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Remove-installer-existence-exists_in_array.patch
Type: text/x-patch
Size: 18408 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Remove-installer-existence-get_specified_file_by_nam.patch
Type: text/x-patch
Size: 2480 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Remove-installer-existence-get_specified_file.patch
Type: text/x-patch
Size: 6849 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Remove-installer-existence.patch
Type: text/x-patch
Size: 11895 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120217/8d651836/attachment-0019.bin>