[PUSHED][REVIEWED] Remove unused code
caolanm at redhat.com
Thu Feb 23 05:47:06 PST 2012
On Thu, 2012-02-23 at 13:03 +0000, Michael Meeks wrote:
> Any thoughts Caolan ?
callcatcher is right, this is a *pure* virtual, i.e. the = 0 of
virtual void dispose() = 0;
Everything that inherits from it has to implement a ::dispose so there's
a virtual method slot created for "dispose" and everything that inherits
from it has to implement a ::dispose which'll be a virtual method.
Typically you don't provide an implementation of a pure virtual, because
you're forcing the inheritors to provide one, but if you *do* then that
implementation itself isn't actually a virtual, and if you want to call
it you have to explicitly call it.
So, in this case, no one has explicitly called the baseclass pure
virtual implementation, so the bodies can go, but to be safe the pure
virtual declarations themselves should stay, i.e.
More information about the LibreOffice