[REVIEW 3.5.1 (?)] fdo#46144: "Distributy Columns Evenly" does not work with the selected columns

Michael Meeks michael.meeks at suse.com
Mon Feb 27 07:01:58 PST 2012

On Mon, 2012-02-27 at 00:53 -0600, Norbert Thiebaud wrote:
> > Fixed invalid conversion from SvUShorts to std::vector... *sigh*
> > Please, pick to the appropriate branches.
> I pushed it on the 3.5 branch.

	With one more review (preferably from a writer maintainer) we're good
for 3.5.1 I think. RC2 is final though Ivan - so we're trying to reduce
the number of patches between RC1 and final of our point releases.

	Having said that I'm not hyper-happy with not initialising the vector's
contents - don't we really want:

	std::vector<sal_uInt16> aWish( aTablCols.Count() + 1, 0 ),
			        aMins( aTabCols.Count() + 1, 0 );

	The previous Max() of the count with 255 looks somewhat odd /
disturbing - no idea what horrors that might hide ;-) sadly that sort of
thing has been there since the beginning.

	Anyhow - thanks for fixing the bug !



michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list