[PATCH] Remove unused code in BiffInputStream

Santiago Martinez smvarela at gmail.com
Mon Feb 27 12:10:56 PST 2012


Hi, i'm not sure if this patch is correct so please review. I deleted
BiffInputStream::sizeBase(), skipByteString(bool) and skipUniString()
methods listed in unusedcode.easy. But also deleted another two methods
(skipUniStringBody and skipUniStringChars ) because these two methods are
used only by previously deleted methods.

I can't find other calls to these methods using "git grep". Also, source
code compiles whithout problems, but I don't know if can be safely deleted
or maybe keept until unusedcode.easy be generated again.

Thanks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120227/40a6e179/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-unused-code-in-BiffInputStream.patch
Type: text/x-patch
Size: 4980 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120227/40a6e179/attachment.bin>


More information about the LibreOffice mailing list