[REVIEW][3.5]fdo#46531, spell checking display fun

Caolán McNamara caolanm at redhat.com
Tue Feb 28 04:26:17 PST 2012

On Mon, 2012-02-27 at 17:07 +0100, Cedric Bosdonnat wrote:
> Hello people,
> Could someone review and cherry-pick -s this commit into -3-5 branch?
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=adf45eced404c33be6db884a3e809725e7975872

FWIW, the nastiness in that SpellDialog is that there are a bunch of
things which would be natural to put directly into the ctor, but they
would require calling virtual methods during construction, which doesn't
work in c++, so there's some lame post-an-event hack and complete the
construction steps that want to call virtuals in the event-callback
which gets called on the next iteration of the main loop after the
construction has completed.

Dialog is fragile and tricky :-(


More information about the LibreOffice mailing list