[PATCH] fdo#33697 Unable to reset "System" as Internet Proxy mode. XPropertyState unsupported

[Caolán McNamara]

On Wed, 2012-02-22 at 13:45 -0800, jumbo444 wrote:
> Hello,
> 
> This patch remove a line preventing the saving of Internet Proxy "System"
> mode. It solves the problem described in fdo#33697.

There's something odd here, RestoreConfigDefaults_Impl is supposed to
basically do the right thing, reset the values to their defaults, but
the cast of m_xConfigurationUpdateAccess to an XPropertyState throws in
SvxProxyTabPage::ReadConfigDefaults_Impl and
SvxProxyTabPage::RestoreConfigDefaults_Impl so all of that reset is
skipped/non-functional.

Looking into configmgr I don't see any mention of XPropertyState in the
list of things an Access supports. Though I do see a mention in (the
unbuilt) configmgr/qa/unit/test.cxx of
//TODO: support setPropertyToDefault

caolanm->sb: What's the story with XPropertyState and
configmgr::Access ? Should Access support XPropertyState so the
XPropertyState stuff in optinet2.cxx works ?, or is it not supposed to
support XPropertyState and the stuff in optinet2.cxx should be changed ?

C.