[REVIEW][3-5-1][3-4] nsplugin broken due to typo
michael.meeks at suse.com
Wed Feb 29 21:21:26 PST 2012
On Wed, 2012-02-29 at 23:24 +0100, Rene Engelhard wrote:
> - mxRemoteMSF->createInstance( ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccessw")) ),
> + mxRemoteMSF->createInstance( ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccess")) ),
> Please sign-off for -3-5-1 and 3-4 (Q: does -3-4 need 1 or 3 reviews?)
If you have a sign-off for -3-5 it will double for -3-4, so I'd just
cherry-pick it there :-)
You have my ack for -3-5-1 - I think you need one more. Nice catch.
I imagine we could write a tool that would dump all string parameters
to 'createInstance' and sanity check them :-) sadly (or happily) people
use a lot of macros for that.
Even better would be for a nice, checked, C++, in-line ( with direct
shortcuts to the C++ factory method if it is in-process ;-) that could
be compiled from the component files in a similar fashion to the
configmgr changes - although, that'd be rather harder for dependency &
scattered .component files reasons.
Anyhow, thanks ! :-)
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice