[Libreoffice] Another code finesse I may have missed

[Olivier Hallot]

    636  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#636>OUnoObject
<http://opengrok.libreoffice.org/s?refs=OUnoObject&project=core>::OUnoObject
<http://opengrok.libreoffice.org/s?refs=OUnoObject&project=core>(*const*
uno <http://opengrok.libreoffice.org/s?defs=uno&project=core>::Reference
<http://opengrok.libreoffice.org/s?defs=Reference&project=core><
report <http://opengrok.libreoffice.org/s?defs=report&project=core>::XReportComponent
<http://opengrok.libreoffice.org/s?defs=XReportComponent&project=core>>&
_xComponent <http://opengrok.libreoffice.org/s?defs=_xComponent&project=core>
   637  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#637>
                      ,*const* ::rtl
<http://opengrok.libreoffice.org/s?defs=rtl&project=core>::OUString
<http://opengrok.libreoffice.org/s?defs=OUString&project=core>&
rModelName <http://opengrok.libreoffice.org/s?defs=rModelName&project=core>
   638  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#638>
                      ,sal_uInt16
<http://opengrok.libreoffice.org/s?defs=sal_uInt16&project=core>
_nObjectType <http://opengrok.libreoffice.org/s?defs=_nObjectType&project=core>)
   639  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#639>
         :SdrUnoObj
<http://opengrok.libreoffice.org/s?defs=SdrUnoObj&project=core>(rModelName
<http://opengrok.libreoffice.org/s?defs=rModelName&project=core>,
sal_True <http://opengrok.libreoffice.org/s?defs=sal_True&project=core>)
   640  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#640>
         ,OObjectBase
<http://opengrok.libreoffice.org/s?defs=OObjectBase&project=core>(_xComponent
<http://opengrok.libreoffice.org/s?defs=_xComponent&project=core>)
641  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#641>
         ,m_nObjectType
<http://opengrok.libreoffice.org/s?defs=m_nObjectType&project=core>(_nObjectType
<http://opengrok.libreoffice.org/s?defs=_nObjectType&project=core>)
642  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#642>{
   643  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#643>
   DBG_CTOR <http://opengrok.libreoffice.org/s?defs=DBG_CTOR&project=core>(
rpt_OUnoObject <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#rpt_OUnoObject>,
NULL <http://opengrok.libreoffice.org/s?defs=NULL&project=core>);
644  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#644>
   impl_setUnoShape
<http://opengrok.libreoffice.org/s?defs=impl_setUnoShape&project=core>(
uno <http://opengrok.libreoffice.org/s?defs=uno&project=core>::Reference
<http://opengrok.libreoffice.org/s?defs=Reference&project=core>< uno
<http://opengrok.libreoffice.org/s?defs=uno&project=core>::XInterface
<http://opengrok.libreoffice.org/s?defs=XInterface&project=core> >(
_xComponent <http://opengrok.libreoffice.org/s?defs=_xComponent&project=core>,
uno <http://opengrok.libreoffice.org/s?defs=uno&project=core>::UNO_QUERY
<http://opengrok.libreoffice.org/s?defs=UNO_QUERY&project=core> ) );
 645  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#645>
   646  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#646>
   *if* ( rModelName
<http://opengrok.libreoffice.org/s?defs=rModelName&project=core>.getLength
<http://opengrok.libreoffice.org/s?defs=getLength&project=core>() )
647  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#647>
       impl_initializeModel_nothrow
<http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#impl_initializeModel_nothrow>();
   648  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#648>
   649  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#649>
   *if* ( rModelName
<http://opengrok.libreoffice.org/s?defs=rModelName&project=core>.getLength
<http://opengrok.libreoffice.org/s?defs=getLength&project=core>() )
650  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#650>
       impl_initializeModel_nothrow
<http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#impl_initializeModel_nothrow>();
   651  <http://opengrok.libreoffice.org/xref/core/reportdesign/source/core/sdr/RptObject.cxx#651>}



Hi

Can someone tell me the 2nd last IF's is not a repetition of the 1st? If it
is, can I drop the second IF?

Thanks

-- 
Olivier Hallot
Founder and Steering Commitee Member
The Document Foundation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120103/1ff1dac9/attachment.html>