[Libreoffice] [PUSHED] [PATCH] Re: minor idl fixes

Tomas Hlavaty tom at logand.com
Thu Jan 5 12:17:44 PST 2012


Hi Michael,

Michael Stahl <mstahl at redhat.com> writes:
> thanks for these patches, i've pushed
> 0001-fix-broken-ifndef-define-guard-in-idl.patch,
> 0002-fix-package-in-idl.patch, 0005-chmod-x-on-java-files.patch.

great!

> 0003-idl-fix-package-names.patch seems to be wrong, as discussed in the
> other mail (and i've fixed the duplicate include guard instead), and

Thank you, I didn't notice the include guard bug.

> 0006-follow-idl-definition.patch/0007-JavaLoader-actually-implements-XImplementationLoader.patch
> were NACKed by Stephan due to backward compatibility.

OK.

> btw, next time please add [PATCH] to the subject so these are more
> visible to devs :)

I will.

Best Regards,

Tomas


More information about the LibreOffice mailing list