[Libreoffice] [PATCH] [PUSHED] msvc doesn't allow dll interface in both class and functions

Stephan Bergmann sbergman at redhat.com
Mon Jan 9 02:12:08 PST 2012


On 01/08/2012 06:20 PM, Korrawit Pruegsanusak wrote:
> IMHO, the problem is caused by part of the commit [1]
> Seems msvc doesn't allow us to have SAL_DLLPUBLIC_EXPORT in both class
> and functions definition. It throws compiler error C2487 [2]
>
> So, I tried to fix with 2 methods:
> 1. Remove dll interface from functions definition, now the whole class
> has dll interface
> 2. Remove dll interface from class definition, and only some functions
> has dll interface
> which I attached both patches.

Fixed in a third way now, 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=2fa19ed7e407188d6af028aad19a2598454959a8>, 
reducing the set of exported symbols to just what is needed by 
extensions/qa/update/test_update.cxx.

Stephan


More information about the LibreOffice mailing list